Skip to content

Comments

[RTD-87] Add validators for BinRangeResponse#177

Draft
and-mora wants to merge 4 commits intodevelopfrom
RTD-87-validation-model
Draft

[RTD-87] Add validators for BinRangeResponse#177
and-mora wants to merge 4 commits intodevelopfrom
RTD-87-validation-model

Conversation

@and-mora
Copy link
Contributor

@and-mora and-mora commented May 23, 2022

Description

This PR adds the validator for ResponseEntity and the relative body BinRangeResponse that will be returned by the bin range api.

List of Changes

  • Changed date format in BinRangeResponse
  • Added validator

Motivation and Context

The response from the bin range api needs to be validated. This will be accomplished by checking the http status and the body inside the response.

  • The http status must be 200.
  • The body is required to have all fields non-null and the size of fileLinks field must be equal to numberOfFiles field.

How Has This Been Tested?

  • Unit Test Suite
  • Integration Test Suite
  • Load Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@and-mora and-mora changed the base branch from master to develop May 23, 2022 09:17
@and-mora and-mora marked this pull request as ready for review May 23, 2022 09:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@TommasoLencioni TommasoLencioni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@and-mora and-mora added the hold label Jan 26, 2024
@and-mora and-mora marked this pull request as draft January 26, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants