Conversation
…SUB-2 step (a)
aprender PR #1516 MERGED on aprender main 2026-05-05 as squash
3138d134d. Companion-only spec record.
**Second substantive code in the M-GPU-MOE-1.4 traced-bisection
chain** (M68 was the helper, M74 wires it). Wires
SaveTensorStage::MoeRouter + MoeFfnOut emission into the CPU
traced MoE forward path per
contracts/trace-moe-gpu-sub-stages-v1.yaml v1.1.0 step (a).
Adds new method `forward_qwen3_moe_traced_with_plan` accepting
`Option<&SaveTensorPlan>`; existing `forward_qwen3_moe_traced`
becomes a thin one-line delegate passing None. Public API
unchanged.
When plan selects MoeRouter or MoeFfnOut for a layer, the last
sequence position's MoE forward dispatches through
moe_ffn_forward_layer_with_router (M68 helper); other positions
use production moe_ffn_forward_layer.
Production forward_qwen3_moe / forward_qwen3_moe_cuda hot paths
byte-unchanged (additive-purity invariant pinned in v1.1.0).
Discharges FALSIFY-MOE-SUB-002 partially at the CPU-traced
surface. Full discharge needs:
- M-MOE-SUB-2 step (b): GPU sibling forward_qwen3_moe_cuda_traced
- M-MOE-SUB-3: live bisection on lambda-vector RTX 4090
- M-GPU-MOE-1.4: fix at bisected stage
Cross-reference bumps:
- README status block: M0–M73 → M0–M74
- CONTRIBUTING status footer: M0–M73 → M0–M74
- Spec status header (line 5): M0–M73 → M0–M74 + M74 narrative
- Spec status snapshot (line 311): M0–M73 → M0–M74
- Run history Run 1 end-M (line 746): M1–M73 → M1–M74
Drift detector PASS — sub-milestones tail M74, gate count 13,
contract v1.23.0, corpus 30/30.
Refs: aprender PR #1516 MERGED 2026-05-05 (squash 3138d134d),
contracts/trace-moe-gpu-sub-stages-v1.yaml v1.1.0 step (a),
M68 helper PR #1507 (squash 0f22c7841)
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records aprender PR #1516 MERGED on aprender main 2026-05-05 as squash `3138d134d` — second substantive code in the M-GPU-MOE-1.4 traced-bisection chain.
Cross-reference bumps
Verification
Refs: aprender #1516 MERGED
🤖 Generated with Claude Code