Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dan Meehan Solution #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,19 @@ GEM
rack
rack-test (0.6.2)
rack (>= 1.0)
rspec (3.1.0)
rspec-core (~> 3.1.0)
rspec-expectations (~> 3.1.0)
rspec-mocks (~> 3.1.0)
rspec-core (3.1.7)
rspec-support (~> 3.1.0)
rspec-expectations (3.1.2)
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.1.0)
rspec-mocks (3.1.3)
rspec-support (~> 3.1.0)
rspec-support (3.1.2)
sass (3.4.24)
sinatra (1.4.5)
rack (~> 1.4)
rack-protection (~> 1.4)
Expand All @@ -66,5 +75,10 @@ DEPENDENCIES
cucumber-sinatra
haml
pry
rspec
rspec-expectations
sass
sinatra

BUNDLED WITH
1.14.6
11 changes: 8 additions & 3 deletions app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def logged_in?
end

post '/login' do
if params[:username] == params[:password]
if params[:username].length > 0 and params[:username] == params[:password]
session[:user] = params[:username]
redirect to '/dashboard'
else
Expand All @@ -31,7 +31,12 @@ def logged_in?
end

get "/dashboard" do
@username = session[:user]
haml :dashboard
if logged_in?
@username = session[:user]
haml :dashboard
else
@message = "You are not logged in"
haml :index
end
end
end
13 changes: 12 additions & 1 deletion features/login.feature
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,15 @@ Feature: Login Page
Given the login page
When I log in with proper credentials
Then I should see the secret page


Scenario: Non-authenticated User
Given the login page
When I log in without proper credentials
Then I should see the login page
And I should get a notice that my credentials are invalid

Scenario: No User
Given the login page
When I log in with no credentials
Then I should see the login page
And I should get a notice that my credentials are invalid
10 changes: 9 additions & 1 deletion features/logout.feature
Original file line number Diff line number Diff line change
@@ -1 +1,9 @@
#Add your codez here
Feature: Logout Page
In order to leave the site securely
As a user
I want to log out and leave the dashboard

Scenario: Logout Authenticated User
Given the dashboard
When I log out
Then I should see the logout page
29 changes: 23 additions & 6 deletions features/step_definitions/login_steps.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,31 @@
Given(/^the login page$/) do
#put your code here
pending
visit('/')
end

When(/^I log in with proper credentials$/) do
#put your code here
pending
fill_in 'username', with: 'user'
fill_in 'password', with: 'user'
click_button 'Login'
end

When(/^I log in without proper credentials$/) do
fill_in 'username', with: 'user'
fill_in 'password', with: 'pass'
click_button 'Login'
end

When(/^I log in with no credentials$/) do
click_button 'Login'
end

Then(/^I should see the secret page$/) do
#put your code here
pending
expect(page.current_path).to eq '/dashboard'
end

Then(/^I should see the login page$/) do
expect(page.current_path).to eq '/login'
end

Then(/^I should get a notice that my credentials are invalid$/) do
expect(page).to have_selector('small', text: 'Your username & password did not match')
end
13 changes: 12 additions & 1 deletion features/step_definitions/logout_steps.rb
Original file line number Diff line number Diff line change
@@ -1 +1,12 @@
#Add your codez here
Given(/^the dashboard$/) do
visit('/')
step 'I log in with proper credentials'
end

When(/^I log out$/) do
click_link 'Logout'
end

Then(/^I should see the logout page$/) do
expect(page.current_path).to eq '/logout'
end