Draft
Conversation
Member
|
we may want to find the varbit for whether jagex's loot tracker is enabled so we can fallback to the legacy event as needed |
Member
this should be fixed in next weeks update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works on #727
Thought I'd start working on this, and making a PR so there's an artifact to test with.
I have purposefully not removed the other notification types, and have added an %EVENT_NAME% template you can add to the notification message so you can more easily compare things.
I'm mostly looking into the first 3 things of the linked issue:
net.runelite.client.events.ServerNpcLootinstead ofnet.runelite.client.events.NpcLootReceivednet.runelite.client.plugins.loottracker.LootReceivedbe removedThings I've tested that work as expected:
Things I've tested that are a bit different:
nvm pickpocketing won't show up in server loot events soonish runelite/runelite@631d320
feel free to push stuff to the pr if you want to play around with things