Skip to content

fix(loot): use jagex loot tracker#732

Draft
pajlada wants to merge 1 commit intomasterfrom
fix/use-server-npc-loot-received
Draft

fix(loot): use jagex loot tracker#732
pajlada wants to merge 1 commit intomasterfrom
fix/use-server-npc-loot-received

Conversation

@pajlada
Copy link
Copy Markdown
Member

@pajlada pajlada commented May 15, 2025

works on #727

Thought I'd start working on this, and making a PR so there's an artifact to test with.
I have purposefully not removed the other notification types, and have added an %EVENT_NAME% template you can add to the notification message so you can more easily compare things.

I'm mostly looking into the first 3 things of the linked issue:

  • Utilize net.runelite.client.events.ServerNpcLoot instead of net.runelite.client.events.NpcLootReceived
  • Investigate to what extent can net.runelite.client.plugins.loottracker.LootReceived be removed
  • Investigate whether any Dink-specific loot logic is obsolete

Things I've tested that work as expected:

  • Opening Coin pouches. Nothing happened before, nothing happens now
  • Killing a simple NPC (tested on Man & Goblin in Lumbridge). Both show up identically

Things I've tested that are a bit different:
nvm pickpocketing won't show up in server loot events soonish runelite/runelite@631d320

feel free to push stuff to the pr if you want to play around with things

@pajlada pajlada changed the title use server npc loot received fix(loot): use jagex loot tracker May 15, 2025
@iProdigy
Copy link
Copy Markdown
Member

we may want to find the varbit for whether jagex's loot tracker is enabled so we can fallback to the legacy event as needed

@Felanbird
Copy link
Copy Markdown
Member

we may want to find the varbit for whether jagex's loot tracker is enabled so we can fallback to the legacy event as needed

this should be fixed in next weeks update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants