feat(notes): link note to specific day via temporal prefix (#232) - #233
Merged
Conversation
…romURI
moment("31", "DD").date() overflows in months with fewer than 31 days
(e.g. June): the moment wraps to the next month, returning 1 instead of 31.
Parse the file string directly as an integer when it is a plain number.
fix(test): align notes-sync base dir between ctrl and global extension
FakeWorkspaceConfig({}) defaulted to ~/Journal while the global extension
used the stale workspace journal.base. Update the workspace setting to a
fresh temp dir so both paths agree and sync can find the note.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Proves 'task mon buy groceries' resolves to Monday with clean text, and 'mond' is correctly left as text (not a valid weekday alias). #149 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
#232 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Parser.resolveNotePathForInput now uses input.generateDate() instead of new Date() so note files are stored under the correct date directory. LoadNotes.loadWithPath forwards offset, date, and scope to the entry link injection instead of hardcoding Input(0) (today). Default offset=0 preserves existing behaviour. #232 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ured locale only) weekdayVocab() and monthVocab() now return English entries plus the entries for the user's configured locale only (primary subtag matched). A German user sees 'so'/'di'/'do' etc; a Dutch user sees 'zo'/'vr'/'za'; neither bleeds into the other. Adds 10 locale-isolation regression tests. Updates input.test.ts German positive-control tests to pass locale='de' explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements Issue #232, allowing users to create notes linked to specific days by prefixing the note title with a temporal expression (e.g., \mon SecurityReview).
Changes
otes-sync.test.ts\ to use isolated temporary directories and workspace configuration, eliminating flaky CI behavior.
Verification
Closes #232. Related to #149 and #177.