Announce node 24 is now the default Node.js version#87
Conversation
| </script> | ||
|
|
||
| {{- $style := resources.Get "scss/main.scss" | resources.ToCSS | resources.Minify -}} | ||
| {{- $style := resources.Get "scss/main.scss" | css.Sass | resources.Minify -}} |
There was a problem hiding this comment.
Running hugo locally with command hugo server -D , it fails due to resources.ToCSS has been deprecated from 0.128 version, based on their documentation https://gohugo.io/functions/resources/tocss/#article instead we should use css.Sass as it says. Practically, this is something internal that hugo uses, and it does not affect the outcome of the website.
There was a problem hiding this comment.
We are quite a few versions behind, https://github.com/paketo-buildpacks/blog/blob/main/.github/workflows/deploy.yml#L27. Not sure if this is supported in the old version too? That would be my only concern making this change.
You might want to omit this for now. We should do a dedicated PR to udpate Hugo.
There was a problem hiding this comment.
Ooops, you are right. Ok, I removed the commit.
There was a problem hiding this comment.
I guess, we would like to have something similar to what we do with jam and pack and in general with all the tools. Like a tools.json file with the version and a bash script that will do the installation locally and will also be used on the github action. That way is also going to be easier to update as we can have an action for doing that, similar to what we do with all the tools. The problem though is still the review process, as we can not be 100% that nothing breaks on the rendering side, in terms of styling etc. but having an installation script, definetely will make the review much easier as it will be easier to install and test it locally
There was a problem hiding this comment.
Yes, that would be a great improvement for running this locally. I have the same issue that I think you're hitting. I install hugo on my own, which means I get the latest, and that's not always aligned with the project. I'll open an issue.
13aaf81 to
053635d
Compare
|
@pacostas I noticed and suggested changes to 2 typos : |
|
@anthonydahanne Oops, you are right, I force pushed and accidentally overridden the typos, I added them 116ef53 Can you also approve and merge the PR? New default nodejs has been also pushed to the builders so we can announce it now. |
Merge after
There is a nodejs release buildpack with the PR from node-engine in it.
Summary
This PR:
hugo server -Dpacostas.jpegtopacostas.jpgUse Cases
Checklist