feat(integration): add action to free space on runner#1237
feat(integration): add action to free space on runner#1237dmikusa merged 7 commits intopaketo-buildpacks:mainfrom
Conversation
Some integration tests, more specifically those for python, often fail with an out of space error. This action frees some space on the runner which allows these tests to pass successfully.
|
I think my biggest concern is taking on a dependency in the form of this 3rd party action that doesn't seem well maintained. There hasn't been a release in a long time and there is at least one PR asking for improvements with no responses. Not that this is an action that needs constant maintenance, but this gives me cause for concern: jlumbroso/free-disk-space#48 Personally, I'd like to see one of the two things happen:
No strong preference which, as both avoid a dependency on a 3rd party. |
|
I think that the second option is a good alternative, in case we would need some additional space we will have all the possible cleanup at hands. |
The original action has not seen much movement lately and the PR adds good improvements. Keeping the code in this repository removes the dependency.
|
I tested the use of the action in paketo-buildpacks/conda-env-update#464 and looks like it's working correctly. |
|
Looks good, one last question. How would one go about setting the env variable to enable this option? The workflow files are managed by this repo, so where would you set that env variable to make it take effect? Would that be in the repo Settings -> Actions? Thanks |
|
I knew I was missing testing something. Well, good thing you asked, I was wrong. It's the vars context I should have used. For the rest, yes, it should be set at the repository level. |
The variables sets through GitHub repository settings are stored in vars (which can be used to fill env). Details: https://docs.github.com/en/actions/reference/workflows-and-actions/contexts#vars-context
Summary
Some integration tests, more specifically those for python, often fail with an out of space error.
This PR adds a new job with an action that frees some space on the runner which allows these tests to pass successfully.
Use Cases
Ensure successful runs of integration tests, more specifically those from the python buildpacks.
See:
paketo-buildpacks/conda-env-update#464
paketo-buildpacks/poetry#555
As example of run failures.
Checklist