feat: new BP_GO_WORKDIR variable #901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce new BP_GO_WORKDIR which can be set as a relative subpath of the whole working directory (--path) as a path where
go buildwill be build from. Meaning effectivelycd into subdir && go build...happens.Use Cases
Use case for mono repos and non-standard repos. The current implementation lacks option for main package to be different to the root of the project.
If a repo has non-standard dependency -- eg. when root is not the "main" package the build fails -- it expects the root to be the main package and derives its dependency tree in standard manner: from root to subdirs. If a repo uses non-standard go dependency tree it needs to build in the main package which means, in this case, from sub directory and this is what BP_GO_WORKDIR aims to enable; differentiate context directory (
--pathwhen pack building) and go workdir directory.fixes #879
Checklist