Open
Conversation
5 tasks
Contributor
|
I think this looks good. @pivotal-david-osullivan I wanted to confirm with you on this? Major or minor change? I think technically we're supposed to use major with removals, but this has also been deprecated for 2 years. We could stick with major and just hold this until we're ready for another major release? It's not urgent to merge this. Thoughts? |
3a5cb33 to
87c0705
Compare
Contributor
|
I think that we should stick to convention and go with major, especially given it's not urgent to get it merged. So yes, once we have enough for a new major we can pull this in 👍 |
pivotal-david-osullivan
approved these changes
May 17, 2023
…BP_BOOT_NATIVE_IMAGE They've been deprecated for 2 years now
87c0705 to
a92afd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BP_BOOT_NATIVE_IMAGE_BUILD_ARGUMENTSandBP_BOOT_NATIVE_IMAGEThey've been deprecated for 2 years now
Checklist