Update all references for PHP7 to 8#543
Closed
oceanicpanda wants to merge 1 commit into
Closed
Conversation
Member
|
Hey! I'd recommend using the instructions here to compile the dependency: https://github.com/paketo-buildpacks/php-dist/blob/main/dependency/actions/compile/README.md |
Member
|
@oceanicpanda can we close out this PR? |
Contributor
Author
|
yep, sorry have been mega busy of late, will try and get back to it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semver:minor
@TisVictress I tried to run the Ruby tests according to https://github.com/paketo-buildpacks/php-dist/blob/main/dependency/actions/compile/binary-builder/README.md however the instructions seem a little broken and I've never used Ruby and copying the commands I could see into the terminal just gave me exceptions I couldn't figure out. Can you please shed some light here?
Summary
Since PHP7 no longer seems to be supported tests should be updated with minimum support versions and all others references should be removed/updated.
Checklist