Skip to content

Conversation

@radoshi
Copy link

@radoshi radoshi commented Apr 19, 2024

  • feat: Install main dependency group only by default
  • fix: resolving PR comments

Summary

This PR is linked to #182 which in turn solves #180

  • Breaking change : default behavior is now to install only main dependency group from pyproject.toml
  • Previous behavior: poetry installs every dependencies, even the ones not necessary for production, regardless of the dependency groups
  • Possibility to specify additional dependency groups with env variable BP_POETRY_INSTALL_WITH, mirroring the --with option from poetry install command
    README.md is updated to describe this new behaviors
  • Unit and integration tests where added

Use Cases

Check #180 discussion for more details

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Mehdi-H and others added 3 commits July 30, 2023 21:25
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2024

CLA Missing ID

  • ✅login: radoshi / (a36ce40)
  • ✅login: radoshi / (a36ce40, f4ba153)
  • ❌ The commit (be22893). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant