Skip to content

Conversation

@TheSuperiorStanislav
Copy link
Contributor

@TheSuperiorStanislav TheSuperiorStanislav commented Sep 5, 2024

Summary

Add the ability to specify which groups will be installed while making the main group as default one

Use Cases

When building for different environments like dev or prod. Would might need some dev tools, while prod is the opposite.

Closes #180

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@TheSuperiorStanislav TheSuperiorStanislav marked this pull request as ready for review September 5, 2024 10:42
@TheSuperiorStanislav TheSuperiorStanislav requested a review from a team as a code owner September 5, 2024 10:42
@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/add-ability-to-install-only-groups branch from 3dd8c1e to c52d39a Compare September 5, 2024 10:55
@TheSuperiorStanislav
Copy link
Contributor Author

@robdimsdale could you take a look? Pretty please)

@TheSuperiorStanislav
Copy link
Contributor Author

@robdimsdale pinging one more time, because our team would like to have it

@TheSuperiorStanislav
Copy link
Contributor Author

@robdimsdale Sorry for pinging, don't want this to go to waste. Could you take a look or ping somebody who could?

@dmikusa
Copy link

dmikusa commented Feb 25, 2025

The PR seems OK to me. I am by no means a poetry expert, but what you're proposing sounds reasonable and it doesn't sound like it will change the existing or default behavior.

The PR is stuck because Github didn't run the tests for some reason. I don't know of a way to fix this, but if you just push up a new commit that should trigger the actions again and hopefully Github will run them this time. I haven't tried, but looks like you can push an empty commit to do this too. Anyway, give that a shot and let me know. I might need to approve them to be run too.

@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/add-ability-to-install-only-groups branch from c52d39a to 7e21fc3 Compare February 26, 2025 05:13
@TheSuperiorStanislav
Copy link
Contributor Author

I guess I need approval
image

@TheSuperiorStanislav
Copy link
Contributor Author

I guess I need approval image

@dmikusa Sorry for ping, but i still need approval to run checks

@dmikusa
Copy link

dmikusa commented Jun 10, 2025

I apologize @TheSuperiorStanislav. All I'm seeing is Waiting for status to be reported, which is something that happens when Github is just in a bad state. There's nothing to approve, it's just stuck. Not sure if this happened cause it timed out or if something just failed to run the jobs. Can you try updating the PR one more time? Just push anything, and it should trigger the PR again. Then ping me on Slack and I'll take a look right away. Apologizes, again. We'll get this sorted.

@dmikusa
Copy link

dmikusa commented Jun 10, 2025

@paketo-buildpacks/python-maintainers Any thoughts on this PR? The issue seems to have quite a few up-votes from the community. Be nice to get something to support this. Thanks

@TheSuperiorStanislav TheSuperiorStanislav force-pushed the feature/add-ability-to-install-only-groups branch from 7e21fc3 to 33a6e4f Compare June 10, 2025 03:18
@jericop
Copy link
Contributor

jericop commented Jun 10, 2025

Thanks for the nudge and apologies for not getting around to looking at this sooner. This is definitely a welcome change, so thanks for this contribution! The PR looks good.

I know the current behavior is to install all dependencies in pyproject.toml, which is not always desired when there are dev dependencies. In my experience most poetry users follow the docs, so I think making this the default should be acceptable. While there is a chance that some users may rely on dev dependencies at run time, this change will encourage recommended configurations in pyproject.toml. I would consider this a minor server change at minimum, but not sure if this warrants a major bump. Any thoughts @dmikusa?

@dmikusa
Copy link

dmikusa commented Jun 10, 2025

I think the intent of Paketo buildpacks has always been to produce production ready containers & this sounds like a way to improve that, so 👍 from me.

It's still a 0.x buildpack, so I would suggest that we bump the minor version to 0.4 and make a note of this behavior change in the release notes & also in the documentation.

https://paketo.io/docs/howto/python/#poetry

Maybe check the samples too, make sure this doesn't break any of them.

@jericop jericop merged commit a0350f4 into paketo-buildpacks:main Jun 10, 2025
11 checks passed
@jericop jericop mentioned this pull request Jul 14, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor A change requiring a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question ❓] How to install only "root/run" dependencies and ignore other groups dependencies

3 participants