-
Notifications
You must be signed in to change notification settings - Fork 8
Add ability to install groups #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to install groups #424
Conversation
3dd8c1e to
c52d39a
Compare
|
@robdimsdale could you take a look? Pretty please) |
|
@robdimsdale pinging one more time, because our team would like to have it |
|
@robdimsdale Sorry for pinging, don't want this to go to waste. Could you take a look or ping somebody who could? |
|
The PR seems OK to me. I am by no means a poetry expert, but what you're proposing sounds reasonable and it doesn't sound like it will change the existing or default behavior. The PR is stuck because Github didn't run the tests for some reason. I don't know of a way to fix this, but if you just push up a new commit that should trigger the actions again and hopefully Github will run them this time. I haven't tried, but looks like you can push an empty commit to do this too. Anyway, give that a shot and let me know. I might need to approve them to be run too. |
c52d39a to
7e21fc3
Compare
|
@dmikusa Sorry for ping, but i still need approval to run checks |
|
I apologize @TheSuperiorStanislav. All I'm seeing is |
|
@paketo-buildpacks/python-maintainers Any thoughts on this PR? The issue seems to have quite a few up-votes from the community. Be nice to get something to support this. Thanks |
7e21fc3 to
33a6e4f
Compare
|
Thanks for the nudge and apologies for not getting around to looking at this sooner. This is definitely a welcome change, so thanks for this contribution! The PR looks good. I know the current behavior is to install all dependencies in pyproject.toml, which is not always desired when there are dev dependencies. In my experience most poetry users follow the docs, so I think making this the default should be acceptable. While there is a chance that some users may rely on dev dependencies at run time, this change will encourage recommended configurations in pyproject.toml. I would consider this a minor server change at minimum, but not sure if this warrants a major bump. Any thoughts @dmikusa? |
|
I think the intent of Paketo buildpacks has always been to produce production ready containers & this sounds like a way to improve that, so 👍 from me. It's still a 0.x buildpack, so I would suggest that we bump the minor version to 0.4 and make a note of this behavior change in the release notes & also in the documentation. https://paketo.io/docs/howto/python/#poetry Maybe check the samples too, make sure this doesn't break any of them. |


Summary
Add the ability to specify which groups will be installed while making the
maingroup as default oneUse Cases
When building for different environments like dev or prod. Would might need some dev tools, while prod is the opposite.
Closes #180
Checklist