Add support for npm based package-lock.json#392
Add support for npm based package-lock.json#392leondmello wants to merge 2 commits intopaketo-buildpacks:mainfrom
npm based package-lock.json#392Conversation
|
@leondmello hey! thanks for the PR. I think that the overall idea totally make sense, I'm just thinking through how this will all fit together in the Ruby buildpack (we will need to add the NPM Install buildpack to an order group). In the mean time, would it be possible to add a basic app and matching integration test, that represents this use case? We have a README in the 6.1 app which explains how we generated the app, but also feel free to copy that app, and make modifications as needed. The matching integration test is here. I'd expect something similar for this use case in the tests, but using NPM Install rather than Yarn Install |
|
Sorry, I missed your comment, will work on that soon |
dee6e51 to
2a4e4b2
Compare
With the latest version of[ shakapacker (v8)](https://github.com/shakacode/shakapacker/blob/v8.0.0/CHANGELOG.md), Rails applications can now use npm as a package manager.
|
@sophiewigmore Can you add a semver label, not sure if the integration tests will run or not if that action is failing |
Summary
Add support for
npmbasedpackage-lock.jsonUse Cases
With the latest version of shakapacker (v8), Rails applications can now use npm as a package manager. This PR makes it so that those apps can leverage the
rails-assetsbuildpack and fixes #393Checklist