Skip to content

Add support for npm based package-lock.json#392

Open
leondmello wants to merge 2 commits intopaketo-buildpacks:mainfrom
leondmello:main
Open

Add support for npm based package-lock.json#392
leondmello wants to merge 2 commits intopaketo-buildpacks:mainfrom
leondmello:main

Conversation

@leondmello
Copy link

@leondmello leondmello commented May 29, 2024

Summary

Add support for npm based package-lock.json

Use Cases

With the latest version of shakapacker (v8), Rails applications can now use npm as a package manager. This PR makes it so that those apps can leverage the rails-assets buildpack and fixes #393

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 29, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@leondmello leondmello marked this pull request as ready for review May 29, 2024 19:13
@leondmello leondmello requested a review from a team as a code owner May 29, 2024 19:13
@sophiewigmore
Copy link
Member

sophiewigmore commented Jun 3, 2024

@leondmello hey! thanks for the PR. I think that the overall idea totally make sense, I'm just thinking through how this will all fit together in the Ruby buildpack (we will need to add the NPM Install buildpack to an order group). In the mean time, would it be possible to add a basic app and matching integration test, that represents this use case?

We have a README in the 6.1 app which explains how we generated the app, but also feel free to copy that app, and make modifications as needed. The matching integration test is here. I'd expect something similar for this use case in the tests, but using NPM Install rather than Yarn Install
Let me know if you have questions

@leondmello
Copy link
Author

Sorry, I missed your comment, will work on that soon

@leondmello leondmello force-pushed the main branch 3 times, most recently from dee6e51 to 2a4e4b2 Compare November 27, 2024 20:06
leondmello and others added 2 commits November 27, 2024 15:09
With the latest version of[ shakapacker (v8)](https://github.com/shakacode/shakapacker/blob/v8.0.0/CHANGELOG.md), Rails applications can now use npm as a package manager.
@leondmello
Copy link
Author

@sophiewigmore Can you add a semver label, not sure if the integration tests will run or not if that action is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for projects using npm instead of yarn

2 participants