Update pluginapitester to apply environment variables in godel.yml#971
Open
nmiyake wants to merge 1 commit into
Open
Update pluginapitester to apply environment variables in godel.yml#971nmiyake wants to merge 1 commit into
nmiyake wants to merge 1 commit into
Conversation
Updates pluginapitester.RunPlugin such that, if a project directory is specified and contains a "godel/config/godel.yml" file, then any settings specified in the "environment" configuration are set as environment variables.
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
tabboud
approved these changes
Dec 5, 2025
Contributor
tabboud
left a comment
tabboud
left a comment
There was a problem hiding this comment.
Overall looks good, just 1 minor nit. Feel free to merge when ready
Comment on lines
+105
to
+106
| if err := os.Setenv(k, v); err != nil { | ||
| return cleanup, errors.Wrapf(err, "failed to set environment variable %s=%s", k, v) |
Contributor
There was a problem hiding this comment.
Very minor nit, but should we also unset the env vars as part of cleanup?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
After this PR
==COMMIT_MSG==
Updates pluginapitester.RunPlugin such that, if a project directory is specified and contains a "godel/config/godel.yml" file, then any settings specified in the "environment" configuration are set as environment variables.
==COMMIT_MSG==
Possible downsides?