Implement several failing safety-analysis test cases #2272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldexis
reviewed
Feb 25, 2025
Comment on lines
+121
to
+160
| @Test | ||
| void testFunctionSafeType() { | ||
| helper().addSourceLines( | ||
| "Test.java", | ||
| "import com.palantir.logsafe.*;", | ||
| "import java.util.function.*;", | ||
| "class Test {", | ||
| " // BUG: Diagnostic contains: Dangerous", | ||
| " Function<@Unsafe String, @Safe String> func = in -> in;", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| void testFunctionConsumesSafetyAnnotatedType_expression() { | ||
| helper().addSourceLines( | ||
| "Test.java", | ||
| "import com.palantir.logsafe.*;", | ||
| "import java.util.function.*;", | ||
| "class Test {", | ||
| " // BUG: Diagnostic contains: Dangerous", | ||
| " Consumer<@Unsafe String> func = in -> fun(in);", | ||
| " void fun(@Safe Object ob) {}", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| void testFunctionConsumesSafetyAnnotatedType_statement() { | ||
| helper().addSourceLines( | ||
| "Test.java", | ||
| "import com.palantir.logsafe.*;", | ||
| "import java.util.function.*;", | ||
| "class Test {", | ||
| " // BUG: Diagnostic contains: Dangerous", | ||
| " Consumer<@Unsafe String> func = in -> { fun(in); };", | ||
| " void fun(@Safe Object ob) {}", | ||
| "}") | ||
| .doTest(); | ||
| } |
aldexis
reviewed
Feb 26, 2025
Comment on lines
+162
to
+174
| @Test | ||
| void testFunctionConsumesSafetyAnnotatedType_reference() { | ||
| helper().addSourceLines( | ||
| "Test.java", | ||
| "import com.palantir.logsafe.*;", | ||
| "import java.util.function.*;", | ||
| "class Test {", | ||
| " // BUG: Diagnostic contains: Dangerous", | ||
| " Consumer<@Unsafe String> func = Test::fun;", | ||
| " void fun(@Safe Object ob) {}", | ||
| "}") | ||
| .doTest(); | ||
| } |
|
This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==COMMIT_MSG==
Implement several failing safety-analysis test cases
==COMMIT_MSG==
Getting these out of my head, into a system!