Use post-processing approach for test report formatting to support Gradle 9#891
Merged
Conversation
Generate changelog in
|
FinlayRJW
changed the title
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 🔄 Changelog entries were re-generated at Mon, 26 Jan 2026 14:20:19 UTC!📋Changelog Preview💡 Improvements
|
CRogers
reviewed
Jan 26, 2026
|
|
||
| // Match <pre> tags within stdout/stderr sections: <h2>standard output</h2>...<pre>...</pre> | ||
| private static final Pattern OUTPUT_SECTION_PATTERN = Pattern.compile( | ||
| "(<h2>standard (?:output|error)</h2>\\s*<span[^>]*>\\s*<pre[^>]*>)(.*?)(</pre>)", |
There was a problem hiding this comment.
one thing to note is whether or not this regex is greedy, which I think you want
Contributor
Author
There was a problem hiding this comment.
I think the current is correct no? The .*? is non-greedy, which is correct here. It stops at the first </pre> after each opening tag, so multiple stdout/stderr sections are matched individually rather than being consumed as one giant match
CRogers
approved these changes
Feb 9, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The
TestReportFormattingPluginrelied on internal Gradle APIs (HtmlTestReport,TestReporter, etc.) using reflection to intercept and format test report output. This approach broke frequently across Gradle versions, requiring version-specific reflection hacks for 8.8, 8.11, and now completelybreaking in 9.3.0 where
org/gradle/api/internal/tasks/testing/report/HtmlTestReportwas removed entirely.After this PR
Replaces the reflection-heavy internal API approach with a simple post-processing strategy. The plugin now uses
FlowScope.always()to run after test tasks complete, walking the generated HTML report directory and reformatting witchcraft log JSON lines in-place. This approach works across all Gradle 8.1+versions including 9.x without version-specific code
==COMMIT_MSG==
Use post-processing approach for test report formatting to support Gradle 9
==COMMIT_MSG==
Possible downsides?
Drops Gradle 7 support. The post-processing happens after test execution completes rather than during report generation, but the end result is equivalent.