feature: implement inner attributes capability#150
Conversation
|
1.68.2.patch |
palfrey
left a comment
There was a problem hiding this comment.
Couple of minor items, but overall very happy with this. Macros are a lot less scary than people think once you get your head around the core concepts :)
…gration test, make error message grammer more clean
abed462 to
f660dcb
Compare
|
Adopted suggested error message change. Thanks for figuring out the lockfile changes to get Overall this MR was pretty easy to do, your existing code was very readable and a great help in figuring out the right way to add this! Thanks for being an awesome maintainer! |
|
@palfrey Bump on this, I believe I've made the needed changes |
|
Apologies, life got in the way! |
Attempts to solve #149
Not super familiar with macro stuff, so I maybe went overkill on the testing, but solution should be good.