Skip to content

feature: implement inner attributes capability#150

Merged
palfrey merged 5 commits intopalfrey:mainfrom
Carter12s:feature/implement-inner-atters
Feb 1, 2026
Merged

feature: implement inner attributes capability#150
palfrey merged 5 commits intopalfrey:mainfrom
Carter12s:feature/implement-inner-atters

Conversation

@Carter12s
Copy link
Contributor

Attempts to solve #149

Not super familiar with macro stuff, so I maybe went overkill on the testing, but solution should be good.

@palfrey
Copy link
Owner

palfrey commented Jan 20, 2026

1.68.2.patch
Took a bit of fiddling, but here's a patch to make the ntest tests build with 1.68.2, as I think they're a good idea. I admit the MSRV does result in some trickiness, but doing things this way around makes sure it's compatible, even if we don't strictly need serial_test_test itself to be compatible!

Copy link
Owner

@palfrey palfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor items, but overall very happy with this. Macros are a lot less scary than people think once you get your head around the core concepts :)

…gration test, make error message grammer more clean
@Carter12s Carter12s force-pushed the feature/implement-inner-atters branch from abed462 to f660dcb Compare January 20, 2026 23:30
@Carter12s Carter12s requested a review from palfrey January 20, 2026 23:33
@Carter12s
Copy link
Contributor Author

Adopted suggested error message change. Thanks for figuring out the lockfile changes to get ntest to build, I also like those tests and was annoyed when I couldn't figure out a working setup with 1.68.

Overall this MR was pretty easy to do, your existing code was very readable and a great help in figuring out the right way to add this! Thanks for being an awesome maintainer!

@Carter12s
Copy link
Contributor Author

@palfrey Bump on this, I believe I've made the needed changes

@palfrey
Copy link
Owner

palfrey commented Feb 1, 2026

Apologies, life got in the way!

@palfrey palfrey merged commit e01cf34 into palfrey:main Feb 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments