Fix/editable form3 #2776
Open
Fix/editable form3 #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now the end user can use editable column independently from column_formatter. - Without this PR, the editable text field container the formatted value NOT the actual one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes #2653. After I read the whole discussion, I think the solution is easier than I thought! simply I have just created a new function
get_unformatted_valuethat supposed to read the actual value without any format and then feed this value to theXEditableWidget.i have created a dedicated test that having both column_editable_list and column_formatter for the same field and it seems works fine.
I have modified the example
examples/sqlato include all datatypes in column_editable_list