fix(peewee): support form_choices in Peewee ModelView#2853
Open
hasansezertasan wants to merge 7 commits into
Open
fix(peewee): support form_choices in Peewee ModelView#2853hasansezertasan wants to merge 7 commits into
hasansezertasan wants to merge 7 commits into
Conversation
hasansezertasan
force-pushed
the
fix/peewee-form-choices
branch
from
088044d to
df74d47
Compare
Override convert() in CustomModelConverter to check form_choices before delegating to wtfpeewee's default conversion. When a field has choices defined, return a Select2Field matching the behavior of the SQLAlchemy contrib. Respects form_overrides priority, builds kwargs with proper validators and filters consistent with the parent converter.
hasansezertasan
force-pushed
the
fix/peewee-form-choices
branch
from
df74d47 to
c29d873
Compare
hasansezertasan
force-pushed
the
fix/peewee-form-choices
branch
from
c29d873 to
9968e0e
Compare
Delegate to the parent ModelConverter and reuse its built kwargs (validators, filters, default, label, description) instead of reconstructing them. Drops imports of wtfpeewee internals (FieldInfo, handle_null_filter, ValueRequired) so future wtfpeewee changes to validator/filter defaults propagate automatically. Also add an integration test covering POST persistence and edit-form pre-population for form_choices.
hasansezertasan
requested review from
ElLorans and
samuelhwilliams
and removed request for
ElLorans
…ices # Conflicts: # flask_admin/tests/peeweemodel/test_basic.py
Contributor
|
This looks solid, but why can't we use the same convert function across the different orms? Maybe we can even upstream it to ModelConverter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
convert()inCustomModelConverterto checkform_choicesbefore delegating to wtfpeewee's default conversion, returning aSelect2Fieldwhen choices are defined (matching the SQLAlchemy contrib behavior)form_choicesin the Peewee test suiteform_choicesusage to thepeewee_simpleexampleFixes #2235
Test plan
pytest flask_admin/tests/peeweemodel/— all 12 tests passpeewee_simpleexample —statusfield renders as a Select2 dropdown