Skip to content

Conversation

The-Podsiadly
Copy link

Built off of @buildpeak's forked PR #41. Added parse_url method to mimic what werkzeug's did. This was copied from flask-restx's PR #463.

Copy link
Collaborator

@bauerji bauerji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please have a look at these comments, than I will try how it works in action

@The-Podsiadly The-Podsiadly force-pushed the feature/41/openapi-docs branch from 43c3cb9 to dfba9ee Compare August 14, 2022 20:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@The-Podsiadly The-Podsiadly requested a review from bauerji August 14, 2022 20:41
@bauerji
Copy link
Collaborator

bauerji commented Aug 28, 2022

@The-Podsiadly Please, check the linter errors in the tests and modify the code accordingly.

Can you please add some tests for the openapi module? I don't like having such a piece of untested code in the code base.

@odie5533
Copy link

Any hope this might get integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants