Skip to content

Conversation

stevanmilic
Copy link

@stevanmilic stevanmilic commented Oct 8, 2024

Resolves #86

  • Adds include_error_url, include_error_context, include_error_input to validate(...) method; the parameters are propagated to pydantic's errors() method. Providing flexibility in terms of using these values that might break serialization.
  • Adds type hints to account for typed error details dict

@stevanmilic stevanmilic force-pushed the feature/issue-22 branch 2 times, most recently from 437d524 to 93566ae Compare October 9, 2024 07:35
@yctomwang
Copy link
Collaborator

looks like the ci has some issue regarding ubuntu with with python3.7, I think it might be time to drop it. Also seems to have some minor lint issue with one unused variable.

@stevanmilic stevanmilic force-pushed the feature/issue-22 branch 2 times, most recently from e678137 to 31ec08d Compare October 14, 2024 14:39
Copy link

@stevanmilic
Copy link
Author

Hi @yctomwang, thanks for review!

I've fixed the lint issue, and removed 3.7 from test matrix. Please take a look 🙏🏻

@stevanmilic
Copy link
Author

Hi @yctomwang, do you have the time to take a look at this PR?

@yctomwang
Copy link
Collaborator

@stevanmilic Hey Steven, I have been extremely busy with work commits but i promise in the next few days i will get to review this!

@stv8
Copy link
Contributor

stv8 commented Apr 15, 2025

hello @stevanmilic, we recently added a significant change to support both pydantic v1 and v2, if you could resolve the conflicts I could look at this again.

Thanks!

- Ensure error location is properly set for both Pydantic v2 and v1 ValidationErrors
- Fixes test failures after rebase where path param validation wasn't catching errors correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Pydantic v2's error object contains a ctx field

3 participants