-
Notifications
You must be signed in to change notification settings - Fork 61
fix: exclude context from pydantic errors #22 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
437d524
to
93566ae
Compare
looks like the ci has some issue regarding ubuntu with with python3.7, I think it might be time to drop it. Also seems to have some minor lint issue with one unused variable. |
e678137
to
31ec08d
Compare
|
Hi @yctomwang, thanks for review! I've fixed the lint issue, and removed 3.7 from test matrix. Please take a look 🙏🏻 |
Hi @yctomwang, do you have the time to take a look at this PR? |
@stevanmilic Hey Steven, I have been extremely busy with work commits but i promise in the next few days i will get to review this! |
hello @stevanmilic, we recently added a significant change to support both pydantic v1 and v2, if you could resolve the conflicts I could look at this again. Thanks! |
31ec08d
to
ef4b997
Compare
- Ensure error location is properly set for both Pydantic v2 and v1 ValidationErrors - Fixes test failures after rebase where path param validation wasn't catching errors correctly
40a823a
to
210d014
Compare
Resolves #86
include_error_url
,include_error_context
,include_error_input
tovalidate(...)
method; the parameters are propagated to pydantic'serrors()
method. Providing flexibility in terms of using these values that might break serialization.