Skip to content

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 21, 2025

@cclauss cclauss force-pushed the patch-1 branch 2 times, most recently from 4a7c997 to 7757cd4 Compare October 21, 2025 15:23
@davidism
Copy link
Member

Please rebase/retarget this to stable.

@cclauss
Copy link
Contributor Author

cclauss commented Oct 21, 2025

You mean that the default branch is not the contribution branch?

@cclauss cclauss changed the base branch from main to stable October 21, 2025 15:56
@cclauss cclauss force-pushed the patch-1 branch 3 times, most recently from f994701 to 7226959 Compare October 21, 2025 16:30
@davidism
Copy link
Member

main is for the next feature release, stable is for fixes to the current feature release.

@davidism
Copy link
Member

Looks like watchdog doesn't support free threading? Need a way to exclude installing it in that environment

@davidism
Copy link
Member

Never mind, that's something else. Watchdog doesn't work on free threading when I run this locally. Also you need to edit the tox list so it tests locally by default as well.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 25, 2025

The watchdog free-threading issue seems fixed (except Windows) in the 1133 pull request on that repo.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 25, 2025

tests/test_serving.py seems to take forever on macOS on GitHub Actions (but not locally).

@davidism
Copy link
Member

Watchdog compiles a C module for fsevents on Mac, and that module is not marked as safe for free threading. Importing it raises a warning that the GIL is being enabled, which defeats the purpose of testing on a free threading build. gorakhargosh/watchdog#1133 does not appear to address that.

@davidism
Copy link
Member

I don't know why the server tests in CI suddenly became slow. I'll try rolling back the dev dependency update.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 26, 2025

Thanks for the update on fsevents. I propose that we drop python3.14t from this PR and focus only on python3.14.

% uvx --with=MacFSEvents python3.14t -c "import fsevents"

@davidism
Copy link
Member

Reported gorakhargosh/watchdog#1140 for the fsevents support.

@cclauss
Copy link
Contributor Author

cclauss commented Nov 26, 2025

Nice changes! Thanks.

@davidism
Copy link
Member

There haven't been a lot of changes recently, so it's hard to tell, but seems like the Mac env has been slow for months. I'll try changing the runner image to 14 or 26 to see if that changes anything. Otherwise, might need to disable the server tests on Mac in CI.

cryptography depends on cffi, which does not support 3.13t, so I'll just keep the 3.14t env.

@davidism
Copy link
Member

Huh, it's the macos-latest (macos-15) that's slow (~14 minutes or timeout). macos-14 just passed in ~30 seconds like all the other envs. Let's try macos-26.

@davidism
Copy link
Member

-26 is slow as well. No code changes, just macos-latest became -15 at some point. Guess I'll set 14 for now and hope things resolve before it's deprecated.

co-authored-by: David Lord <[email protected]>
@cclauss
Copy link
Contributor Author

cclauss commented Nov 26, 2025

Py3.13t was experimental while Py3.14t is not so I don’t see a need to support the former.

@davidism davidism merged commit 5d79f1a into pallets:stable Nov 26, 2025
13 checks passed
@cclauss cclauss deleted the patch-1 branch November 26, 2025 21:40
@davidism
Copy link
Member

https://cloudisland.nz/@freakboy3742/115621860432520698 The slow network is a known issue with macOS 15+ runners, presumably Apple will fix it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants