Remove ThinElement #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Yes my issue is a ThickElement will throw an error if user define the length as 0. I’m ok with deleting ThinElement as proposed in this pull request, maybe an easy solution to my problem is to make the length of ThickElement |
wlin6927
approved these changes
Dec 3, 2025
Member
|
Thanks for the feedback, Lucy!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this implements @ax3l's suggestion in #47 (comment), though I'm not sure if it really addresses @wlin6927's original concern raised in #47 (comment) (which I interpreted as something along the lines of "a
Kickerelement could be either thick or thin", etc.).