Optimization of costly Augeas() invocation, so it doesn't load all modules - #12
Open
adamryczkowski wants to merge 2 commits into
Open
Optimization of costly Augeas() invocation, so it doesn't load all modules#12adamryczkowski wants to merge 2 commits into
adamryczkowski wants to merge 2 commits into
Conversation
adamryczkowski
force-pushed
the
master
branch
from
October 29, 2015 08:54
ffd104f to
84ad828
Compare
Author
|
The second commit is a further optimization; it reads the Unfortunately, I wasn't able to cleanly infer the augeas: >
commands='match /files/etc/default/lxc-net/LXC_BRIDGE'
filter=inclPlease, don't merge this commit yet, I'm still testing this (I'll let you know when I'm ready) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I thought that the performance hit was from the Augeas invocation around the line 443, but further testing proved the problem was in completely different place.
Now the net speed of running the play with a single augeas task on localhost from over 1.2 sec to the 0.3 sec (and that includes all other overheads associated with invocation of ansible).
(The first pull request had a typo, that's why I had to delete it).