Add promptable YOLOE ONNX support#27
Draft
vlordier wants to merge 10 commits into
Draft
Conversation
There was a problem hiding this comment.
Code Review
This pull request expands the library's capabilities to support YOLOE models and custom label configurations, enabling users to specify class labels through CLI arguments or external files. The core inference engine was updated to accommodate dynamic input/output names and flexible tensor layouts, specifically addressing models with additional detection channels. Review feedback highlights a logic issue where providing a subset of labels could lead to misclassification, identifies redundant error handling in the label retrieval process, and notes an unreachable error variant that should be removed for cleanliness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds promptable YOLOE ONNX support while keeping the currently validated scope explicit after the docs cleanup.
Validated scope
exported-promptable-yoloe-26n/bundle, so that reviewer fixture is still local-only.What changed
output0coefficients plusoutput1prototypestokenizers--label,--labels-file,--prompt,--prompt-encoder-model,--prompt-tokenizer,--rect, and--no-displayValidation
cargo test --libcargo test promptable_rect_png_fixture_matches_python_baseline --test promptable_parity -- --ignoredNotes