Update README.md #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brkoslav04
approved these changes
Mar 17, 2024
ChefMist
reviewed
Mar 19, 2024
| forge script script/01_DeployVault.s.sol:DeployVaultScript -vvv \ | ||
| --rpc-url $RPC_URL \ | ||
| --broadcast \ | ||
| --slow \ | ||
| --verify | ||
| ``` | ||
|
|
||
| Note you will need to update the `script/config/xxx.json` file to set the vault address that was created in order to deploy the PoolManagers. |
There was a problem hiding this comment.
thanks for raisng PR. Would you mind removing this line?
Thinking of placing this line within the deployment script as each script would have different pre-requisite note. thanks
cynthiaa14pohfletcher
approved these changes
Mar 19, 2024
cyuxhtby
added a commit
to cyuxhtby/pancake-v4-core
that referenced
this pull request
Jul 22, 2024
leo42000
suggested changes
Apr 6, 2025
| @@ -21,7 +21,7 @@ The scripts are located in `/script` folder, deployed contract address can be fo | |||
| // set script config: /script/config/{SCRIPT_CONFIG}.json | |||
| export SCRIPT_CONFIG=ethereum-sepolia | |||
|
|
|||
| // set rpc url | |||
| // set rpc url | |||
| @@ -33,14 +33,16 @@ export ETHERSCAN_API_KEY=xx | |||
|
|
|||
| ### Execute | |||
There was a problem hiding this comment.
Suggested change
| ### Execute | |
| ### Execute |
Suggested change
| ### Execute | |
| ### Execute |
|
|
||
| Example. within `script/01_DeployVault.s.sol` | ||
| ``` | ||
| // remove --verify flag if etherscan_api_key is set | ||
| // remove --verify flag if etherscan_api_key is not set |
There was a problem hiding this comment.
Suggested change
| // remove --verify flag if etherscan_api_key is not set | |
| // remove --verify flag if etherscan_api_key is not set |
Suggested change
| // remove --verify flag if etherscan_api_key is not set | |
| // remove --verify flag if etherscan_api_key not is set |
leo42000
reviewed
Apr 6, 2025
| forge script script/01_DeployVault.s.sol:DeployVaultScript -vvv \ | ||
| --rpc-url $RPC_URL \ | ||
| --broadcast \ | ||
| --slow \ | ||
| --verify | ||
| ``` | ||
|
|
leo42000
reviewed
Apr 6, 2025
| @@ -44,3 +44,5 @@ forge script script/01_DeployVault.s.sol:DeployVaultScript -vvv \ | |||
| --slow \ | |||
| --verify | |||
| ``` | |||
|
|
|||
| Note you will need to update the `script/config/xxx.json` file to set the vault address that was created in order to deploy the PoolManagers. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the readme.