Skip to content

fix: Currency list token buttons mobile #12493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: Currency list token buttons mobile #12493

wants to merge 2 commits into from

Conversation

@memoyil
Copy link
Collaborator

@memoyil memoyil commented Oct 29, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on improving the user experience and functionality of tooltip behavior and UI components in the application. It includes enhancements in event handling and minor adjustments to component props.

Detailed summary

  • Added onClick and onTouchStart event handlers to the ViewOnExplorerButton to stop event propagation.
  • Corrected a typo in a comment regarding lodash's debounce functionality.
  • Enhanced toggleTooltip logic to handle clickable children elements.
  • Removed unnecessary useEffect related to tooltip visibility.
  • Simplified ComplementSection component by removing isSelected prop.
  • Updated defaultTooltipMessage in ComplementSection based on mobile detection.
  • Changed onClick prop in CurrencyRow to be undefined when isSelected is true.
  • Adjusted the ComplementSection usage in CurrencyRow to remove the isSelected prop.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ed3eed3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Nov 13, 2025 11:47am
8 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
aptos-web Ignored Ignored Nov 13, 2025 11:47am
blog Ignored Ignored Nov 13, 2025 11:47am
bridge Ignored Ignored Nov 13, 2025 11:47am
games Ignored Ignored Nov 13, 2025 11:47am
gamification Ignored Ignored Nov 13, 2025 11:47am
solana Ignored Ignored Nov 13, 2025 11:47am
ton Ignored Ignored Nov 13, 2025 11:47am
uikit Ignored Ignored Nov 13, 2025 11:47am

@memoyil memoyil marked this pull request as draft October 29, 2025 09:03
@memoyil memoyil force-pushed the feature/fix_currency_list_token_buttons_mobile branch from 977fb04 to 2ca0d74 Compare October 29, 2025 09:06
@memoyil memoyil force-pushed the feature/fix_currency_list_token_buttons_mobile branch from 2ca0d74 to c0748b4 Compare October 29, 2025 09:45
memoyil
memoyil commented Oct 29, 2025
View reviewed changes
packages/uikit/src/hooks/useTooltip/useTooltip.tsx
}, [trigger, targetElement, hideTooltip, showTooltip, manualVisible, tooltipElement, debouncedHide]);

// no longer need the extra useeffect
const toggleTooltip = useCallback(
Copy link
Collaborator Author

@memoyil memoyil Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it is in mobile and button / a make tooltip visible, it will do stopPropagation on the first click to show the tooltip only without action. otherwise existing logic will be applied

@memoyil memoyil marked this pull request as ready for review October 29, 2025 09:53
memoyil
memoyil commented Oct 29, 2025
View reviewed changes
apps/web/src/components/SearchModal/CurrencyList.tsx
showActions,
}: {
selectedCurrency: Currency
isSelected: boolean
Copy link
Collaborator Author

@memoyil memoyil Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isSelected not used

@memoyil memoyil force-pushed the feature/fix_currency_list_token_buttons_mobile branch from 9504e84 to c643e7b Compare November 2, 2025 10:27
@memoyil memoyil force-pushed the feature/fix_currency_list_token_buttons_mobile branch from c643e7b to bf29d2a Compare November 11, 2025 05:56
@memoyil memoyil force-pushed the feature/fix_currency_list_token_buttons_mobile branch from bf29d2a to ed3eed3 Compare November 13, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chef-Yogi Chef-Yogi Awaiting requested review from Chef-Yogi

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

@chefphilip chefphilip Awaiting requested review from chefphilip chefphilip is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@memoyil