Skip to content

fix: Inverted price confirm modal when creating pool with native #12507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: Inverted price confirm modal when creating pool with native #12507

wants to merge 3 commits into from

Conversation

@memoyil
Copy link
Collaborator

@memoyil memoyil commented Nov 7, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on optimizing and refactoring code across various components in the application, improving performance and readability, and ensuring better handling of state and filters.

Detailed summary

  • Combined two filters into one in the PositionPage.tsx to streamline filtering logic.
  • Updated useV3CreateForm to use baseCurrency.wrapped for sorting.
  • Removed unused dependencies from useV3CreateForm.
  • Simplified useActiveChainId to directly return state from accountActiveChainAtom.
  • Added unifiedAccount to AccountChainState in accountStateAtoms.ts.
  • Enhanced useCurrencyBalancesWithChain to improve memoization of currencies.
  • Refactored useInfinityPositions to combine filtering and sorting logic.
  • Cleaned up imports and removed unused variables in several files for better clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web Ready Ready Preview Comment Nov 20, 2025 0:51am
8 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
aptos-web Ignored Ignored Nov 20, 2025 0:51am
blog Ignored Ignored Nov 20, 2025 0:51am
bridge Ignored Ignored Nov 20, 2025 0:51am
games Ignored Ignored Nov 20, 2025 0:51am
gamification Ignored Ignored Nov 20, 2025 0:51am
solana Ignored Ignored Nov 20, 2025 0:51am
ton Ignored Ignored Nov 20, 2025 0:51am
uikit Ignored Ignored Nov 20, 2025 0:51am

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: d2bfe0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@memoyil memoyil force-pushed the feature/fix_inverted_price_when_creating_native_pool branch 3 times, most recently from dcb915e to ae4bfdb Compare November 7, 2025 06:48
memoyil
memoyil commented Nov 7, 2025
View reviewed changes
apps/web/src/views/CreateLiquidityPool/hooks/V3/useV3CreateForm.tsx
baseCurrency &&
quoteCurrency &&
isUnifiedCurrencySorted(baseCurrency as unknown as UnifiedCurrency, quoteCurrency as unknown as UnifiedCurrency),
isUnifiedCurrencySorted(
Copy link
Collaborator Author

@memoyil memoyil Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed here, rest of the changes are fixing deps warnings with reducing usememo overhead and account chain hook atom

@memoyil memoyil force-pushed the feature/fix_inverted_price_when_creating_native_pool branch from ae4bfdb to b4d52dc Compare November 11, 2025 05:28
@memoyil memoyil force-pushed the feature/fix_inverted_price_when_creating_native_pool branch from db08d05 to a76c083 Compare November 11, 2025 08:58
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 13, 2025
memoyil
memoyil commented Nov 13, 2025
View reviewed changes
apps/web/src/state/wallet/hooks.ts
const tokens = useMemo(
() => currencies?.filter((currency): currency is Token => Boolean(currency?.isToken)) ?? [],
// eslint-disable-next-line react-hooks/exhaustive-deps
[...(currencies ?? [])],
Copy link
Collaborator Author

@memoyil memoyil Nov 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might cause issues on dev build, currently one usage of this hook which is already memoized so it is safe to use currencies directly

@memoyil memoyil force-pushed the feature/fix_inverted_price_when_creating_native_pool branch from 40aa738 to 088b299 Compare November 13, 2025 11:30
@memoyil memoyil force-pushed the feature/fix_inverted_price_when_creating_native_pool branch from 088b299 to d2bfe0d Compare November 20, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chefjackson chefjackson Awaiting requested review from chefjackson chefjackson is a code owner

@ChefJerry ChefJerry Awaiting requested review from ChefJerry ChefJerry is a code owner

@thechefpenguin thechefpenguin Awaiting requested review from thechefpenguin thechefpenguin is a code owner

@chef-eric chef-eric Awaiting requested review from chef-eric chef-eric is a code owner

@chef-ryan chef-ryan Awaiting requested review from chef-ryan chef-ryan is a code owner

@chefphilip chefphilip Awaiting requested review from chefphilip chefphilip is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@memoyil