feat: Implement safe price update logic in pool swaps #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `safeUpdatePoolPrice` function to ensure price updates are validated against previous prices with a defined jump factor. - Introduced `isSane` function to check price sanity based on a maximum allowed price change. - Updated `handleSwap` to utilize the new price update logic, improving price integrity during swaps. - Added `MAX_JUMP_FACTOR` constant to control price movement limits.
- Deleted legacy code that addressed pricing issues for a specific block (18450862) in the handleSwap function. - This cleanup improves code readability and maintains focus on current pricing logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safeUpdatePoolPricefunction to ensure price updates are validated against previous prices with a defined jump factor.isSanefunction to check price sanity based on a maximum allowed price change.handleSwapto utilize the new price update logic, improving price integrity during swaps.MAX_JUMP_FACTORconstant to control price movement limits.Net effect: no schema changes; subgraph no longer persists corrupted price/tick, avoids ETH/USD inversion, and remains robust if slot0 call reverts or both sources are bad.
Todo: Extend the same changes to the
litesubgraph as well