Use sentinel value instead of Option.none - #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Switch capture buffers/updates to ValidPosPlusOne with a sentinel, updating strategies, APIs, and correctness lemmas.
Option (ValidPos s)withValidPosPlusOne sacross capture buffers (Regex.CapturedGroups.buffer), NFA updates/buffers, and materialization.ValidPosPlusOne(≤,or/orElse, validity lemmas, conversions) used by runtime and proofs.BuffernowVector (ValidPosPlusOne s); empty initialized with.sentinel s.BufferStrategy.writewrites.validPos;materializeUpdates/AuxproduceValidPosPlusOnebuffers.equivPosand adaptEquivMaterializedUpdateand its lemmas (eq,eq_none).Regex.searchNextandCapturedGroups.getread start/stop asValidPosPlusOne, gate onstop.isValidandstart ≤ stop, and convert viaasValidPos.cghelper now emits.validPos/.sentinelinstead ofsome/none.grind.materializeUpdatesproducing sentinel-based buffers.Written by Cursor Bugbot for commit a6f4712. This will update automatically on new commits. Configure here.
Benchmark results
It appears that the upgrade to
v4.26.0-rc2improved the throughput by a few percent. This might be due to a better compiler or usingValidPos(which directly compiles to aNat) instead ofIterator(which may allocate a two field cell on everyit.next). Moreover, the PR replacesOption (ValidPos s)withValidPosPlusOne sin the capture group buffer, getting rid of allocation associated withOptionby representing an invalid position with a sentinel value outside of the valid range withins. The optimization resulted in another a few percentage improvement, and now we can benchmarkcurated/03-date/asciiwithin the time limit!