Unicode RL1.1 support: Add \u{...} Hex Notation for Full Unicode Range - #149
Merged
pandaman64 merged 4 commits intoDec 24, 2025
Merged
Conversation
pandaman64
requested changes
Dec 23, 2025
pandaman64
left a comment
Owner
There was a problem hiding this comment.
PRありがとうございます!全体的には良いのですが、細部についてコメントしたので取り入れてもらえると助かります。
yuuki14202028
marked this pull request as ready for review
December 24, 2025 10:50
3 tasks
pandaman64
approved these changes
Dec 24, 2025
pandaman64
left a comment
Owner
There was a problem hiding this comment.
LGTMです。コントリビューションありがとうございます!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
\u{...}escape sequence to support the full Unicode range, addressing #136.Changes
Regex.Syntax.Parserto handle variable-length hex sequences enclosed in braces (e.g.,\u{1F600}).0x0to0x10FFFF) and are not surrogate pairs.\uXXXXand\xXXescapes.regex/Regex/Syntax/Parser/Test.leanfrom Issue.Note
Unicode escape support and validation
\u{...}parsing inescapedCharviahexEscape/unicodeEscapesupporting 1–6 hex digits, falling back to\uHHHH; preserves\xHHand\uHHHHisValidChar; introduce errorsinvalidCodePointandtooManyHexDigitswith messages inError.lean}, out-of-range and surrogate code points)Written by Cursor Bugbot for commit b928866. This will update automatically on new commits. Configure here.