Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MaskType to other cases #1073

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Conversation

loicdiridollou
Copy link
Contributor

@loicdiridollou loicdiridollou marked this pull request as ready for review December 16, 2024 03:07
@loicdiridollou
Copy link
Contributor Author

There was also one other place (

) but I was a little unsure if MaskType was the appropriate behavior there, open to feedback.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at core/series.pyi. The logical operations like __and__(), __or__(), etc. have the same issue. Can you make the change there as well?

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 63dfe96 into pandas-dev:main Dec 17, 2024
10 checks passed
@loicdiridollou loicdiridollou deleted the mask_type branch January 9, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check usage of Series[bool] and see if MaskType is more appropriate
2 participants