Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1088 Test Migration pt1 #1121

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Conversation

loicdiridollou
Copy link
Contributor

@loicdiridollou loicdiridollou commented Feb 16, 2025

This is a subset of the changes for GH1089 since it has just become a much bigger issue than I intended in the first place so splitting the changes to only have migration of the tests and another PR will address changes in the pyi files.

@loicdiridollou loicdiridollou changed the title GH1089 Test Migration pt1 GH1088 Test Migration pt1 Feb 16, 2025
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this, but wondering why you didn't convert all of the test statements.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit e35a729 into pandas-dev:main Feb 20, 2025
10 checks passed
@loicdiridollou loicdiridollou deleted the gh1089_migration_pt1 branch March 9, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants