TYP: #1447 #1867 @override in pandas-stubs/_libs/tslibs/timestamps.pyi - #1871
Merged
Conversation
cmp0xff
force-pushed
the
override-timestamp
branch
5 times, most recently
from
August 6, 2026 07:32
efd307a to
5161b8f
Compare
cmp0xff
force-pushed
the
override-timestamp
branch
from
August 6, 2026 09:30
5161b8f to
f53d890
Compare
loicdiridollou
approved these changes
Aug 6, 2026
loicdiridollou
left a comment
loicdiridollou
left a comment
Member
There was a problem hiding this comment.
Looks good thanks @cmp0xff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typing_extensions.override#1447 CLN: #1836 mergepyrefly_strictintopyrefly, makety_allandpyrefly_allpassing #1867. It turns out that all type checkers have rules requiring@override, whereaspyreflyandtyhave them on with their "strict" modes. In this PR I am adding all required@overrides inpandas-stubs/_libs/tslibs/timestamps.pyias an example to review the idea.reportImplicitOverride)assert_type()to assert the type of any return value)AGENTS.md.