BUG: relocate to_offset and other pyrefly-inspired changes - #1878
Merged
Conversation
cmp0xff
force-pushed
the
pyrefly-only-changes
branch
2 times, most recently
from
August 6, 2026 09:30
eea8d2f to
b3cf1f8
Compare
cmp0xff
force-pushed
the
pyrefly-only-changes
branch
from
August 6, 2026 14:01
b3cf1f8 to
65ee77e
Compare
Dr-Irv
reviewed
Aug 6, 2026
| return x.max() - k * x.min() | ||
|
|
||
| check( | ||
| # pyrefly: ignore[implicity-any-lambda] |
Collaborator
There was a problem hiding this comment.
IMHO, I think we should always ignore this from pyrefly, because the pattern of doing lambdas this way is common.
Contributor
Author
There was a problem hiding this comment.
What about pyright reportUnknownLambdaType?
Collaborator
There was a problem hiding this comment.
same - I don't think we should be expecting our tests to handle that, because it is pretty natural to NOT add types to lambda functions.
My philosophy on the tests is that we want to have in our tests code that people are likely to write. Trying to make that fully compliant with any/all type checkers with some of the more strict errors puts a burden on people using the code. We can make our own choices as to which error messages we are willing to support.
3 tasks
Dr-Irv
pushed a commit
that referenced
this pull request
Aug 7, 2026
…`implicity-any-lambda` (#1879) * facebook/pyrefly#4427 * facebook/pyrefly#4439 * facebook/pyrefly#4443 * pyrefly implicit-any-lambda * pyrefly and pyright * pyright_all * remove private api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to_offsethas been moved frompandas-stubs/tseries/frequencies.pyitopandas-stubs/_libs/tslibs/offsets.pyi.pyrefly_strictintopyrefly, makety_allandpyrefly_allpassing #1867 which is giganticassert_type()to assert the type of any return value)AGENTS.md.