Use Pyrefly for type-coverage instead of pyright - #1910
Open
MarcoGorelli wants to merge 6 commits into
Open
Conversation
3 tasks
MarcoGorelli
marked this pull request as draft
August 20, 2026 17:04
MarcoGorelli
commented
Aug 20, 2026
Comment on lines
+54
to
+55
| - name: Verify type completeness using pyrefly | ||
| run: poetry run poe type_completeness |
Member
Author
There was a problem hiding this comment.
this now takes 2 seconds in CI, so I think it's fine to run it alongside the other checks rather than in a separate job
MarcoGorelli
marked this pull request as ready for review
August 20, 2026 17:12
loicdiridollou
left a comment
loicdiridollou
left a comment
Member
There was a problem hiding this comment.
One minor question, the rest looks great!
| "pyright>=1.1.410", | ||
| "ty>=0.0.67", | ||
| "pyrefly>=1.1.0", | ||
| "pyrefly (>=1.2.0)", |
Member
There was a problem hiding this comment.
Shouldn’t we keep the same format as the other specifications for this section? Like “pyrefly>=1.2.0”
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1883 and keeps @loicdiridollou as co-author
closes #1795