Remove versioneer / setuptools #57941
Conversation
| dynamic = [ | ||
| 'version' | ||
| ] | ||
| version = "3.0.0.dev0" |
There was a problem hiding this comment.
Does this get rid of the commit info in the version?
If so, I'd be -1 on this.
(It may be useful for downstream to pin to a previous pandas nightly)
There was a problem hiding this comment.
No the scripts that generate the version.py file will append the git revision to the end of this
There was a problem hiding this comment.
I don't think this worked.
The filename shows up as 3.0.0.dev0 (at least on the sdist)
There was a problem hiding this comment.
Maybe I misunderstood the question. If you run interactively you will see the version:
>>> import pandas as pd
+ /usr/local/bin/ninja
[1/1] Generating pandas/generate-version with a custom command
Saving version to pandas/_version.py
>>> pd.__version__
'3.0.0.dev0+git20240321.84fbbb0'
Is the sdist folder name important?
There was a problem hiding this comment.
I think so yes - pinning versions is based on the version in the sdist/wheel filename IIRC.
If you try reverting this change, do we get the git commit in the filename again?
There was a problem hiding this comment.
_build_version/gitversion.py:L16 expects this to be version = ... - if you revert it back to the 'dynamic' key that no longer works
There was a problem hiding this comment.
I checked an sdist build with NumPy and they have the exact same behavior as here - is there a reason why we want to differ from them?
There was a problem hiding this comment.
Doesn't this make it so that the nightlies all basically have the same version?
(IIRC, pip figures out the version of the package from the filename, and it's hardcoded to 3.0.0dev0 for both the wheels and the sdist)
There was a problem hiding this comment.
Are we storing a longer term snapshot of the nightlies somewhere? On Anaconda I only see 5 days worth:
https://anaconda.org/scientific-python-nightly-wheels/pandas/files
NumPy only stores one day worth and no sdist:
https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/numpy/
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing since there hasn't been much activity here, but feel free to reopen if/when you have time to revisit |
|
@lithomas1 we are dropping setuptools support for 3.0 right? |
|
I don't think the setuptools stuff is maintained anymore. (I just forgot to remove it) I think my main objection was to the versioneer stuff. |
trying to follow the lead set by numpy/numpy#24196
@lithomas1