ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append #60829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeTT404
changed the title
mroeschke
reviewed
Feb 3, 2025
mroeschke
reviewed
Feb 3, 2025
mroeschke
reviewed
Feb 3, 2025
mroeschke
reviewed
Feb 3, 2025
mroeschke
added
Error Reporting
…Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code.
JakeTT404
force-pushed
the
Wrong-error-message-in-HDFStore.append
branch
from
04a8169 to
500ab5a
Compare
…s. Move nan_rep tests into separate function.
…-in-HDFStore.append
|
I've removed the comments mentioned and reverted the error type. I've replaced the test with a function of 3 tests testing the following cases:
There may be some odd git stuff during me updating the main branch due to my unfamiliarity with the GitHub contribution workflow and git as a whole. |
…-in-HDFStore.append
mroeschke
approved these changes
Feb 5, 2025
|
Thanks @JakeTT404 |
5 tasks
|
This impacted #60795 - #60795 (comment) Is this okay to backport to 2.3? |
|
Yup sure OK with me |
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Feb 10, 2025
…edge case in HDFStore.append (pandas-dev#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec)
5 tasks
|
Backport PR: #60907 |
mroeschke
pushed a commit
that referenced
this pull request
Feb 10, 2025
#60907) ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) Co-authored-by: Jake Thomas Trevallion <[email protected]>
mroeschke
pushed a commit
that referenced
this pull request
Feb 16, 2025
…0916) * ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) * TST(string dtype): Resolve xfails in pytables (#60795) (cherry picked from commit 4511251) * Adjust test --------- Co-authored-by: Jake Thomas Trevallion <[email protected]>
mroeschke
pushed a commit
that referenced
this pull request
Feb 20, 2025
…ading with condition (#60967) * ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) * TST(string dtype): Resolve xfails in pytables (#60795) (cherry picked from commit 4511251) * BUG(string dtype): Resolve pytables xfail when reading with condition (#60943) (cherry picked from commit 0ec5f26) --------- Co-authored-by: Jake Thomas Trevallion <[email protected]>
mroeschke
pushed a commit
that referenced
this pull request
Feb 20, 2025
* ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) * TST(string dtype): Resolve xfails in pytables (#60795) (cherry picked from commit 4511251) * BUG(string dtype): Resolve pytables xfail when reading with condition (#60943) (cherry picked from commit 0ec5f26) * Backport PR #60940: ENH: Add dtype argument to str.decode --------- Co-authored-by: Jake Thomas Trevallion <[email protected]>
mroeschke
pushed a commit
that referenced
this pull request
Feb 22, 2025
…cked strings (#60984) * ENH: Improved error message and raise new error for small-string NaN edge case in HDFStore.append (#60829) * Add clearer error messages for datatype mismatch in HDFStore.append. Raise ValueError when nan_rep too large for pytable column. Add and modify applicable test code. * Fix missed tests and correct mistake in error message. * Remove excess comments. Reverse error type change to avoid api changes. Move nan_rep tests into separate function. (cherry picked from commit 57340ec) * TST(string dtype): Resolve xfails in pytables (#60795) (cherry picked from commit 4511251) * BUG(string dtype): Resolve pytables xfail when reading with condition (#60943) (cherry picked from commit 0ec5f26) * Backport PR #60940: ENH: Add dtype argument to str.decode * Backport PR #60938: ENH(string dtype): Implement cumsum for Python-backed strings --------- Co-authored-by: Jake Thomas Trevallion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pytables.py to improve error messages caused by datatype mismatches in HDFStore.append. Also added ValueError for when the NaN representation cannot fit into the column. Modified tests concerning the improved error message and added new test for when column is type string with length <3 and as such nan_rep 'nan' is too big.