Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: Update NumpyExtensionArray repr for NEP51 #61085

Merged
merged 7 commits into from
Mar 12, 2025
Merged

DEPS: Update NumpyExtensionArray repr for NEP51 #61085

merged 7 commits into from
Mar 12, 2025

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Mar 8, 2025 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Continuation of #54268

@rhshadrach rhshadrach marked this pull request as ready for review March 9, 2025 13:51
@rhshadrach rhshadrach added Output-Formatting __repr__ of pandas objects, to_string ExtensionArray Extending pandas with custom dtypes or arrays. labels Mar 9, 2025
@rhshadrach rhshadrach modified the milestones: 3.0, 2.3 Mar 9, 2025
@rhshadrach
Copy link
Member Author

@mroeschke - since yours went into 2.1, I was thinking it'd make sense to put this in 2.3. But no objection to holding off until 3.0 either.

mroeschke
mroeschke approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm OK with this going in 2.3. Just would need a whatsnew entry

@rhshadrach
Copy link
Member Author

@mroeschke - whatsnew added.

@mroeschke mroeschke merged commit 3c93d06 into pandas-dev:main Mar 12, 2025
42 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Mar 12, 2025
@rhshadrach @meeseeksmachine
Backport PR pandas-dev#61085: DEPS: Update NumpyExtensionArray repr f…
2ca831d 
…or NEP51
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 12, 2025
Merged
mroeschke pushed a commit that referenced this pull request Mar 12, 2025
@meeseeksmachine @rhshadrach
Backport PR #61085 on branch 2.3.x (DEPS: Update NumpyExtensionArray …
47bc953 
…repr for NEP51) (#61107)

Backport PR #61085: DEPS: Update NumpyExtensionArray repr for NEP51

Co-authored-by: Richard Shadrach <[email protected]>
@rhshadrach rhshadrach deleted the bug_nep51_reprs branch March 12, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
ExtensionArray Extending pandas with custom dtypes or arrays. Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke