DOC: Remove outdated comment, use DateOffset instead of BaseOffset in docs #61097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
changed the title
rhshadrach
reviewed
Mar 11, 2025
rhshadrach
reviewed
Mar 11, 2025
pandas/core/arrays/categorical.py
Outdated
Comment on lines
2977
to
2979
| if (res := method(*args, **kwargs)) is not None: | ||
| return Series(res, index=self._index, name=self._name) |
There was a problem hiding this comment.
These are no more readable (honestly they seem even be less readable) and don't impact behavior or performance. Seems like needless code churn to me, but if others really want this no strong objection.
There was a problem hiding this comment.
that's fair, I'll revert 👍
MarcoGorelli
force-pushed
the
remove-outdated-comment
branch
from
9ac3eca to
53f658d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DateOffsetalways be used instead ofBaseOffset? #60886PeriodDtype.from_date_offsetwas removed in REF: de-duplicate hard-coded unit code #46338