Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/TST: Address TestArrowArray::test_reduce_series_numeric supporting skew #61098

Merged
merged 5 commits into from
Mar 11, 2025
Merged

CI/TST: Address TestArrowArray::test_reduce_series_numeric supporting skew #61098

merged 5 commits into from
Mar 11, 2025

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Mar 10, 2025
@mroeschke mroeschke added this to the 2.3 milestone Mar 10, 2025
datapythonista
datapythonista approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @mroeschke for taking care of this!

@datapythonista datapythonista merged commit 89bc204 into pandas-dev:main Mar 11, 2025
42 checks passed
@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Mar 11, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 89bc204e94cda860085865081cd18cd1d130cec1
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61098: CI/TST: Address TestArrowArray::test_reduce_series_numeric supporting skew'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61098-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61098 on branch 2.3.x (CI/TST: Address TestArrowArray::test_reduce_series_numeric supporting skew)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

mroeschke added a commit to mroeschke/pandas that referenced this pull request Mar 11, 2025
@mroeschke
Backport PR pandas-dev#61098: CI/TST: Address TestArrowArray::test_re…
e89f94a 
…duce_series_numeric supporting skew
@mroeschke mroeschke deleted the enh/arrow/skew branch March 11, 2025 17:23
mroeschke added a commit that referenced this pull request Mar 13, 2025
@mroeschke
Backport PR #61098: CI/TST: Address TestArrowArray::test_reduce_serie…
00d8d2a 
…s_numeric supporting skew (#61102)

* Backport PR #61098: CI/TST: Address TestArrowArray::test_reduce_series_numeric supporting skew

* remove skew from check

* Remove kurt too

* Add skew to bool skip list

* Add boolean

* bool fails regardless of skipna
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @datapythonista