BUG: Fix nanany/nanall raising ValueError with skipna=False on nullable dtypes#65835
Open
factnn wants to merge 1 commit into
Open
BUG: Fix nanany/nanall raising ValueError with skipna=False on nullable dtypes#65835factnn wants to merge 1 commit into
factnn wants to merge 1 commit into
Conversation
…ypes When skipna=False and NA values are present (from nullable boolean/integer dtypes), nanany and nanall try to convert NaN to bool via astype(bool), which raises ValueError. Return NaN directly instead. Fixes GH#65710
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65710:
DataFrame.any(skipna=False)andDataFrame.all(skipna=False)raiseValueError: cannot convert float NaN to boolon nullable dtypes (boolean,Int*,Float*), whileSeries.any/all(skipna=False)correctly returnspd.NA.Root Cause
In
nanops.nananyandnanops.nanall, whenskipna=Falseand NA values are present,_get_valuespreserves NaN values in the array. Thenvalues.astype(bool)tries to convert NaN to bool, which raisesValueError.Fix
Check for NaN values when
skipna=Falsebefore attemptingastype(bool), and returnnp.nandirectly instead.Changes
pandas/core/nanops.py: 6 lines each innananyandnanallFixes #65710
Co-authored-by: Claude noreply@anthropic.com