BUG: Series.sort_values ignore_index has no effect on already sorted Series (#65833)#65836
Open
rahul-COD3 wants to merge 3 commits into
Open
BUG: Series.sort_values ignore_index has no effect on already sorted Series (#65833)#65836rahul-COD3 wants to merge 3 commits into
rahul-COD3 wants to merge 3 commits into
Conversation
rhshadrach
requested changes
Jun 9, 2026
Author
|
Added a test for the already-sorted case ( |
rahul-COD3
force-pushed
the
main
branch
3 times, most recently
from
3a60bd1 to
cb55245
Compare
rhshadrach
requested changes
Jun 13, 2026
…as-dev#65833) When a Series is already sorted, sort_values() takes an early return path that bypasses the ignore_index reset. Move the ignore_index check into the early return path so it is applied in all cases.
…as-dev#65833) Refactor early return in sort_values to be more DRY per review feedback. Move whatsnew entry from Indexing to Reshaping section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When a Series is already sorted,
sort_values()returns early without applyingignore_index.Root cause: The early return path (for the already-sorted case) at
pandas/core/series.py:4081copied the Series directly without checkingignore_index.Fix: Move the
ignore_indexindex reset into the early return path for both theinplaceand non-inplacebranches.Closes #65833