BUG: track CoW references through Index.where#65846
Open
jbrockmendel wants to merge 2 commits into
Open
Conversation
Follow-up to GH#65265 review comments: construct the intermediate Series and result Index from pandas objects instead of raw arrays so CoW references are tracked in no-copy cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to post-merge review comments on GH-65265 (cc @jorisvandenbossche).
Index.whereconstructed the intermediate Series and the result Index from raw._values, so CoW references were not tracked whenSeries.wheretook a no-copy path. Passing the pandas objects through the constructors (which pick up_referenceswhencopy=False) restores correct tracking; unreleased regression, so no whatsnew.🤖 Generated with Claude Code