BUG: DataFrame loc set incorrectly aligns on scalar column assignment…#65852
Open
pranavchoudhary-tech wants to merge 5 commits into
Open
Conversation
…pandas-dev#58482) When setting a scalar column with a DataFrame value using , pandas would take a single-block fastpath that completely skipped alignment, resulting in the assignment proceeding purely by position. This updates to extract the correct column from the DataFrame and align it properly before using the fastpath.
Author
|
I've pushed a fix that resolves the TypeError test failures in the CI. The dataframe alignment logic is no longer being bypassed during the single-block fast path, and all test_loc checks are passing locally. Ready for review! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… (#58482)
When setting a scalar column with a DataFrame value using , pandas would take a single-block fastpath that completely skipped alignment, resulting in the assignment proceeding purely by position. This updates
to extract the correct column from the DataFrame
and align it properly before using the fastpath.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.