TST: assert helpful errors for never-supported pyarrow read_csv cases#65861
Open
jbrockmendel wants to merge 1 commit into
Open
TST: assert helpful errors for never-supported pyarrow read_csv cases#65861jbrockmendel wants to merge 1 commit into
jbrockmendel wants to merge 1 commit into
Conversation
Convert pyarrow-engine xfails that can never pass (intentionally unsupported options) to assert the helpful error message instead, using the established raises-and-return pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jbrockmendel
added
Testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many pyarrow-engine read_csv xfails can never pass: they exercise options the engine intentionally rejects (list/callable
skiprows, regex separators, non-defaultquoting,thousands,nrows,chunksize,dayfirst, dict/non-stringna_values). For these, the best we can do is raise a helpful error — which we already do — so convert the xfails to assert that message, using the raises-and-return pattern already common in these files.request.applymarker(e.g.test_skip_rows_bug[6],test_null_quote_charwith default quoting)Test-only; no behavior change.
🤖 Generated with Claude Code