CLN: remove the deprecated is_sparse function#65867
Open
natmokval wants to merge 1 commit into
Open
Conversation
| @@ -1027,17 +1027,17 @@ def test_dataframe_to_sql_arrow_dtypes(conn, request): | |||
| if conn == "sqlite_adbc_conn": | |||
| df = df.drop(columns=["timedelta"]) | |||
| if pa_version_under14p1: | |||
Member
There was a problem hiding this comment.
does this suggest its time to bump our pyarrow min-version?
Contributor
Author
There was a problem hiding this comment.
I don't know about plans to change the minimum required pyarrow version. Can we require a more recent pyarrow version in this particular case to make the test pass, while the general minimum required version is lower?
Contributor
Author
There was a problem hiding this comment.
Or maybe we should wait until v4 before enforcing this deprecation?
Member
There was a problem hiding this comment.
I don’t think we can require a different version in different places. @jorisvandenbossche can comment on if it’s too soon to bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref #52642
Enforced the deprecation of the
is_sparsefunction.