Skip to content

DOC: add FY5253 and FY5253Quarter constructor signatures - #71845

Open
Wrethis wants to merge 2 commits into
pandas-dev:mainfrom
Wrethis:doc-fy5253-signature
Open

Wrethis wants to merge 2 commits into
pandas-dev:mainfrom
Wrethis:doc-fy5253-signature

Conversation

@Wrethis

@Wrethis Wrethis commented Nov 2, 2026

Copy link
Copy Markdown

This adds constructor signatures for FY5253 and FY5253Quarter to doc/source/signature_overrides.py, as part of #70457.

FY5253 uses weekday=0 and startingMonth=1 as defaults, but the existing "weekday" and "startingMonth" entries default to None (used by Week and the quarter offsets). So I added separate fy_weekday and fy_startingMonth entries that keep the real parameter names but have the right defaults.

I checked that the signatures match the constructors by running apply_signature_overrides() locally.

Note: #71797 renames startingMonth on FY5253, so whichever PR is merged second will need a small update.

I used Claude Code (Claude Opus 5.5, effort: medium) to help understand the issue. I reviewed and tested it myself.

Copilot AI balanced review requested due to automatic review settings November 2, 2026 14:47

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@jbrockmendel jbrockmendel added this to the 3.2 milestone Nov 2, 2026
# Conflicts:
#	doc/source/signature_overrides.py
@github-actions github-actions Bot added the Awaiting Review PR in the maintainers' court; exempt from staleness label Nov 3, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting Review PR in the maintainers' court; exempt from staleness

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants