Text tweak of Skeleton.ipynb#375
Closed
Coderambling wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks @Coderambling, but the answer is no, options have to be manually added in panel-material-ui to be exposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulse, wave and none are all the options available currently in MUI.
https://mui.com/material-ui/react-skeleton/
Should the doc include a sentence like: Please refer to the MUI Skeleton component page to see the most recent list of options.
So if MUI adds more variants besides Pulse and Wave in the future, and the MUI version is bumped in pmui, will that new variants automatically work in the pmui Chip component?
Does this apply to all situations where MUI gains new variants in a component, like in the scenario above?
Just a thought:
This could be solved by:
-Interrogating the pmui component during build of docs.
-Extract the current list of variants this way.
-Create an alert that something has changed, so docs need to be updated accordingly.
-Insert the extracted list of variants in the docs automatically during build.
Or would that be too complicated / not worth the effort to implement this?