Skip to content

Various fixes for docked Drawer variant sizing/positioning #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
philippjfr merged 1 commit into from
Jul 14, 2026
Merged

Various fixes for docked Drawer variant sizing/positioning #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions src/panel_material_ui/layout/Drawer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,13 @@ export function render({model, view}) {
if (!inline) { return }
if (isDocked) {
if (isHorizontal) {
view.el.style.width = open ? `${size + TAB_SIZE}px` : `${TAB_SIZE}px`
view.el.style.width = open ? `${size + TAB_SIZE}px` : "0px"
view.el.style.height = "100%"
view.el.style.overflow = "visible"
} else {
view.el.style.height = open ? `${size + TAB_SIZE}px` : `${TAB_SIZE}px`
view.el.style.height = open ? `${size + TAB_SIZE}px` : "0px"
view.el.style.width = "100%"
view.el.style.overflow = "visible"
}
} else {
if (isHorizontal) {
Expand All @@ -147,13 +149,16 @@ export function render({model, view}) {

if (isDocked) {
if (inline) {
// Inline docked: same structure as fixed docked but scoped to a relative container.
// Inline docked: container collapses to 0 when closed; the tab is absolutely
// positioned so it overlays adjacent content rather than pushing it.
const containerStyle = {
position: "relative",
[isHorizontal ? "width" : "height"]: open ? `${size + TAB_SIZE}px` : `${TAB_SIZE}px`,
[isHorizontal ? "width" : "height"]: open ? `${size + TAB_SIZE}px` : "0px",
[isHorizontal ? "height" : "width"]: "100%",
transition: "width 225ms cubic-bezier(0, 0, 0.2, 1), height 225ms cubic-bezier(0, 0, 0.2, 1)",
overflow: "visible",
pointerEvents: "none",
flexShrink: 0,
}

const innerStyle = {
Expand All @@ -163,6 +168,19 @@ export function render({model, view}) {
pointerEvents: "auto",
}

const closedTabStyle = (() => {
const offsetSide = anchor === "left" ? "right" : anchor === "right" ? "left" : anchor === "top" ? "bottom" : "top"
return {
position: "absolute",
[offsetSide]: `-${TAB_SIZE}px`,
...getPositionStyle(anchor, dockPosition),
width: isHorizontal ? `${TAB_SIZE}px` : `${TAB_LENGTH}px`,
height: isHorizontal ? `${TAB_LENGTH}px` : `${TAB_SIZE}px`,
pointerEvents: "auto",
zIndex: 1200,
}
})()

return (
<div style={containerStyle}>
<div style={innerStyle}>
Expand All @@ -181,7 +199,9 @@ export function render({model, view}) {
<DockedTab anchor={anchor} open={open} dockPosition={dockPosition} attached onClick={() => setOpen(false)} />
</Drawer>
{!open && (
<DockedTab anchor={anchor} open={false} dockPosition={dockPosition} attached={false} onClick={() => setOpen(true)} />
<div style={closedTabStyle}>
<DockedTab anchor={anchor} open={false} dockPosition={dockPosition} inline attached={false} onClick={() => setOpen(true)} />
</div>
)}
</div>
</div>
Expand Down
Loading